[FIX] UiKit/DatePicker is broken#4607
Merged
Merged
Conversation
reinaldonetof
commented
Oct 14, 2022
| onShow(false); | ||
| if (date || timestamp) { | ||
| const newDate = date || new Date(timestamp); | ||
| unstable_batchedUpdates(() => { |
Contributor
Author
There was a problem hiding this comment.
We need this unstable_batchedUpdates to avoid double re-render of the calendar when using Android
diegolmello
approved these changes
Oct 20, 2022
diegolmello
pushed a commit
that referenced
this pull request
Dec 2, 2022
* [FIX] UiKit/DatePicker is broken * minor tweak
diegolmello
pushed a commit
that referenced
this pull request
Dec 2, 2022
* [FIX] UiKit/DatePicker is broken * minor tweak
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* [FIX] UiKit/DatePicker is broken * minor tweak
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* [FIX] UiKit/DatePicker is broken * minor tweak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
To access this functionality, you need to login open.rocket.chat and send /remind into the message box
Then, when clicking the input When? the iOS is crashing, and the Android is returning Invalid Date after selecting the data.
Issue(s)
How to test or reproduce
/remind, then send itScreenshots
iOS
Screen.Recording.2022-10-14.at.15.02.34.mov
Android
Screen.Recording.2022-10-14.at.16.18.41.mov
Types of changes
Checklist
Further comments
Jira: NATIVE-91