feat: quote above user message by OtavioStasiak · Pull Request #6121 · RocketChat/Rocket.Chat.ReactNative

OtavioStasiak · 2025-01-31T21:47:30Z

Proposed changes

Move quote above user message to looks like web/desktop.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-502

How to test or reproduce

open the app;
go to roomView;
quote a message;

Screenshots

Before	After

Types of changes

Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Documentation update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Further comments

diegolmello

Isn't just a matter of moving this line above content?

OtavioStasiak · 2025-03-17T14:10:02Z

Isn't just a matter of moving this line above content?

I don't think so because once you move attachments above the content, you're not just changing the position of the quote but also all types of attachments, such as images and videos.

diegolmello

Fix lint and missing stories

OtavioStasiak · 2025-09-09T15:53:39Z

Fix lint and missing stories

Simulator Screenshot - iPhone 16 - 2025-09-09 at 12 48 57

we already have stories for quote.

chore: quote above user message

60133fb

OtavioStasiak marked this pull request as ready for review January 31, 2025 21:49

OtavioStasiak added 2 commits March 14, 2025 17:22

Merge branch 'develop' into chore-quoted-message-above-the-user-message

3a2a314

Merge branch 'develop' into chore-quoted-message-above-the-user-message

eba8277

diegolmello changed the title ~~chore: quote above user message~~ feat: quote above user message Mar 17, 2025

diegolmello requested changes Mar 17, 2025

View reviewed changes

Merge branch 'develop' into chore-quoted-message-above-the-user-message

47b94b4

OtavioStasiak had a problem deploying to approve_e2e_testing September 9, 2025 14:16 — with GitHub Actions Error

OtavioStasiak and others added 2 commits September 9, 2025 14:17

chore: format code with Prettier [skip ci]

3e04591

fix: remove Quote from attachments

4787917

OtavioStasiak had a problem deploying to approve_e2e_testing September 9, 2025 14:37 — with GitHub Actions Error

diegolmello requested changes Sep 9, 2025

View reviewed changes

fix: snapshot test

8822370

OtavioStasiak had a problem deploying to approve_e2e_testing September 9, 2025 15:26 — with GitHub Actions Error

OtavioStasiak had a problem deploying to experimental_ios_build September 9, 2025 15:28 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_ios_build September 9, 2025 15:28 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_android_build September 9, 2025 15:28 — with GitHub Actions Error

OtavioStasiak had a problem deploying to experimental_android_build September 9, 2025 15:28 — with GitHub Actions Error

diegolmello approved these changes Sep 9, 2025

View reviewed changes

diegolmello requested changes Sep 9, 2025

View reviewed changes

Comment thread app/containers/message/Components/Attachments/Attachments.tsx

Comment thread app/containers/message/__snapshots__/Message.test.tsx.snap Outdated

fix: empty gap views

1bd6d9e

OtavioStasiak had a problem deploying to approve_e2e_testing September 9, 2025 16:34 — with GitHub Actions Error

OtavioStasiak had a problem deploying to experimental_android_build September 9, 2025 16:37 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_android_build September 9, 2025 16:37 — with GitHub Actions Error

OtavioStasiak had a problem deploying to experimental_ios_build September 9, 2025 16:37 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_ios_build September 9, 2025 16:37 — with GitHub Actions Error

fix: prevent empty views

d4ef0b4

OtavioStasiak had a problem deploying to approve_e2e_testing September 9, 2025 16:53 — with GitHub Actions Error

OtavioStasiak had a problem deploying to approve_e2e_testing September 9, 2025 17:00 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_ios_build September 9, 2025 17:03 — with GitHub Actions Error

OtavioStasiak had a problem deploying to experimental_ios_build September 9, 2025 17:03 — with GitHub Actions Error

OtavioStasiak had a problem deploying to experimental_android_build September 9, 2025 17:03 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_android_build September 9, 2025 17:03 — with GitHub Actions Error

chore: code improvements

f655c7a

OtavioStasiak had a problem deploying to approve_e2e_testing September 9, 2025 17:04 — with GitHub Actions Error

diegolmello requested changes Sep 9, 2025

View reviewed changes

Comment thread app/containers/message/Components/Attachments/Quote.tsx Outdated

OtavioStasiak had a problem deploying to experimental_android_build September 9, 2025 17:06 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_android_build September 9, 2025 17:06 — with GitHub Actions Error

OtavioStasiak had a problem deploying to experimental_ios_build September 9, 2025 17:06 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_ios_build September 9, 2025 17:06 — with GitHub Actions Error

chore: rename function

01f15f9

OtavioStasiak had a problem deploying to approve_e2e_testing September 9, 2025 17:08 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_android_build September 9, 2025 17:10 — with GitHub Actions Error

OtavioStasiak had a problem deploying to experimental_android_build September 9, 2025 17:10 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_ios_build September 9, 2025 17:10 — with GitHub Actions Error

OtavioStasiak had a problem deploying to experimental_ios_build September 9, 2025 17:10 — with GitHub Actions Error

diegolmello approved these changes Sep 9, 2025

View reviewed changes

Merge branch 'develop' into chore-quoted-message-above-the-user-message

7c3aa92

diegolmello had a problem deploying to approve_e2e_testing September 9, 2025 17:11 — with GitHub Actions Failure

diegolmello merged commit 965ac53 into develop Sep 9, 2025
4 of 7 checks passed

diegolmello deleted the chore-quoted-message-above-the-user-message branch September 9, 2025 17:11

diegolmello had a problem deploying to experimental_android_build September 9, 2025 17:13 — with GitHub Actions Failure

diegolmello had a problem deploying to official_ios_build September 9, 2025 17:13 — with GitHub Actions Failure

diegolmello had a problem deploying to experimental_ios_build September 9, 2025 17:13 — with GitHub Actions Failure

diegolmello had a problem deploying to official_android_build September 9, 2025 17:13 — with GitHub Actions Failure

coderabbitai Bot mentioned this pull request Sep 23, 2025

regression: Collapsible quote not rendering after #6121 #6677

Merged

10 tasks

diegolmello added a commit that referenced this pull request Sep 24, 2025

regression: Collapsible quote not rendering after #6121 (#6677)

14b131c

OtavioStasiak pushed a commit that referenced this pull request Oct 21, 2025

regression: Collapsible quote not rendering after #6121 (#6677)

13b55db

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: quote above user message#6121

feat: quote above user message#6121
diegolmello merged 13 commits into
developfrom
chore-quoted-message-above-the-user-message

OtavioStasiak commented Jan 31, 2025

Uh oh!

diegolmello left a comment

Uh oh!

OtavioStasiak commented Mar 17, 2025

Uh oh!

diegolmello left a comment

Uh oh!

OtavioStasiak commented Sep 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

OtavioStasiak commented Jan 31, 2025

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

Checklist

Further comments

Uh oh!

diegolmello left a comment

Choose a reason for hiding this comment

Uh oh!

OtavioStasiak commented Mar 17, 2025

Uh oh!

diegolmello left a comment

Choose a reason for hiding this comment

Uh oh!

OtavioStasiak commented Sep 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants