fix: added default value in useUserPreferences#6855
Conversation
WalkthroughAdded explicit default values to several Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
🧰 Additional context used🧬 Code graph analysis (1)app/containers/ImageViewer/ImageViewer.tsx (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes
The useUserPreferences hook expects both a key and a default value, but during the migration from react-native-mmkv-storage to react-native-mmkv, we forgot to add the default value for the accessibility setting. Because of this missing default value, the switch stopped working and did not reflect state changes.
Introduced in #6744
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
Bug Fixes
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.