chore: enable jest cache and broaden worktree ignore pattern#7156
Merged
Conversation
Contributor
WalkthroughJest configuration and gitignore updates to manage cache directory, ignore worktrees in module and test path patterns, and store Jest cache in a project-local directory. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Speeds up local
yarn testruns by enabling a persistent Jest cache and broadens the worktree ignore pattern so tests in any*/worktrees/*directory (e.g..worktrees/,.claude/worktrees/,.omc/worktrees/,.superset/worktrees/) are skipped — not just the root.worktrees/.Changes:
jest.config.js.worktrees/intestPathIgnorePatternswith regex<rootDir>/.*worktrees/so any parent directory containing aworktrees/folder is ignored. Anchoring to<rootDir>ensures the pattern does not match when Jest is invoked from inside a worktree (the worktree's own tests still run).modulePathIgnorePatterns(previous entry was scoped only to.worktrees/).cacheDirectory: '<rootDir>/.jest-cache'to persist Jest's transform cache across runs. Warm runs of./app/lib/services/voipwent from ~56s to ~2s locally..gitignore.jest-cache/.Issue(s)
https://rocketchat.atlassian.net/browse/CORE-2103
How to test or reproduce
yarn test ./app/lib/services/voiptwice.*/worktrees/*path, drop a.test.tsthere, and confirmyarn test(from the main checkout) does not pick it up.yarn testand confirm that the worktree's own tests still run and its cache is stored at<worktree>/.jest-cache(separate from the main checkout).Screenshots
N/A
Types of changes
Checklist
Further comments
The speedup was tracked to a broken local Watchman binary on macOS (missing
libfmt.11.dylibafter a Homebrew upgrade); however the Jest cache change is beneficial regardless of Watchman state and is safe for CI (actions/cachecan optionally be wired up later to persist.jest-cachebetween CI runs, but is not required for correctness).Summary by CodeRabbit