fix(voip): null-check RNCallKeepModule.instance on killed-app incoming call (Android)#7189
Merged
diegolmello merged 1 commit intoApr 20, 2026
Conversation
…vice When app is killed and an incoming VoIP call arrives, VoiceConnectionService starts before React Native initializes, so RNCallKeepModule.instance is null. Guard the getCurrentReactActivity() call to prevent NPE crash.
diegolmello
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Failure
Contributor
|
Important Review skippedToo many files! This PR contains 232 files, which is 82 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (32)
📒 Files selected for processing (232)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
had a problem deploying
to
experimental_ios_build
GitHub Actions
Failure
diegolmello
had a problem deploying
to
official_ios_build
GitHub Actions
Failure
diegolmello
temporarily deployed
to
experimental_android_build
GitHub Actions
Inactive
diegolmello
had a problem deploying
to
official_android_build
GitHub Actions
Failure
diegolmello
added a commit
that referenced
this pull request
Apr 20, 2026
diegolmello
added a commit
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix fatal NPE crash when receiving a VoIP call with the app killed on Android.
VoiceConnectionService.startForegroundService()callsRNCallKeepModule.instance.getCurrentReactActivity()at line 322, butinstanceis null when the app has been killed — React Native hasn't initialized yet, so the static singleton is never set.Patch adds a null-guard: if
instanceis null,currentActivityis null, and the existingif (currentActivity != null)block already handles that gracefully (skips attaching a PendingIntent to the notification).Issue(s)
Crash stack trace:
How to test or reproduce
Screenshots
N/A
Types of changes
Checklist
Further comments
The
RNCallKeepModule.instancestatic is set ingetInstance()which is called during React Native module initialization. When Android's Telecom framework startsVoiceConnectionServicein response to an incoming call on a killed app, the RN runtime hasn't started yet, soinstanceremains null.