chore: switch @rocket.chat/media-signaling to npm 1.0.0-rc.1#7264
Conversation
Drop the vendored tarball (packages/rocket.chat-media-signaling-0.2.0.tgz) and resolve the dependency from the npm registry instead. dist/ is byte-identical between 0.2.0 and 1.0.0-rc.1; this is purely a dependency-source swap.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used🧠 Learnings (8)📓 Common learnings📚 Learning: 2026-02-05T13:55:00.974ZApplied to files:
📚 Learning: 2026-03-31T11:59:31.061ZApplied to files:
📚 Learning: 2026-03-31T11:58:54.608ZApplied to files:
📚 Learning: 2026-03-30T15:49:30.957ZApplied to files:
📚 Learning: 2026-04-22T22:57:58.545ZApplied to files:
📚 Learning: 2026-04-22T22:57:58.545ZApplied to files:
📚 Learning: 2026-04-22T22:57:58.545ZApplied to files:
🔇 Additional comments (1)
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
left a comment
There was a problem hiding this comment.
Review — #7264 — 2026-04-28T14:38:00Z
Findings: 2 (critical: 0, major: 0, minor: 1, nit: 1, spec-mismatch: 0)
Verdict: APPROVE
Skipped (duplicate of existing thread): 0
Posted by Claude (cadence-babysit) for plan 2026-04-28-apply-media-signaling, slice 01-swap-tarball-for-npm. Reviewed against headRefOid 16411aa68c41eb94fde7d1314655df2504f5972b and the slice spec at slices/01-swap-tarball-for-npm.md.
The diff matches every acceptance criterion verbatim. No app/ source edits (correctly out of scope — dist/ is byte-identical between 0.2.0 and 1.0.0-rc.1). The yarn.lock rewrite is the expected mechanical regen and carries the new integrity hash. Minor observations follow.
minor: Pinned to a release-candidate version
Path: package.json:48
Category: design
Suggested fix: Track a follow-up to bump to a stable 1.0.0 once published; the PR description already calls this out and a separate slice is the right place.
The dependency now reads "@rocket.chat/media-signaling": "1.0.0-rc.1" — pinned exactly (no ^ / ~), which is the right call for an rc because semver-range bumps to a later -rc aren't safe under yarn's prerelease semantics. As of 2026-04-28 that's the only published version on the registry, so there's no alternative. Worth filing the stable-bump as its own slice so the registry-tracking story has a clear next step.
nit: Empty packages/ directory
Path: packages/rocket.chat-media-signaling-0.2.0.tgz
Category: style
Suggested fix: If packages/ is now empty (only contained the deleted tarball), remove the directory along with the file so the working tree doesn't carry a stray empty folder. Git won't track the empty dir on its own, but local checkouts on case-sensitive filesystems can keep it around.
The slice spec explicitly calls this out (If packages/ becomes empty after this delete, remove the directory too). From the diff alone we can't tell whether packages/ had any other files; if the executor verified it was the only content, this is satisfied implicitly. Calling it out so the reviewer can confirm during merge.
Proposed changes
Switches the
@rocket.chat/media-signalingdependency from a vendored tarballto the npm registry. The package is now published as
@rocket.chat/media-signaling@1.0.0-rc.1.Concretely:
package.json:"file:./packages/rocket.chat-media-signaling-0.2.0.tgz"->"1.0.0-rc.1"packages/rocket.chat-media-signaling-0.2.0.tgzdeleted (and the now-emptypackages/directory along with it).yarn.lockregenerated;@rocket.chat/media-signalingnow resolves fromhttps://registry.yarnpkg.com/...instead offile:./packages/....The compiled
dist/of0.2.0and1.0.0-rc.1is byte-identical — only package metadata changed (version bump, MIT license, repo URL, removedprivate: true). No source changes underapp/are needed; existing imports inapp/lib/services/voip/MediaSessionInstance.ts,MediaSessionStore.ts,useCallStore.ts,MediaCallLogger.ts, andapp/lib/services/restApi.tscontinue to work unchanged.This follows the established dependency-bump pattern from PR #7153 (the prior
0.2.0bump in this area), but flips the source from local tarball to the published registry version.Part of plan
2026-04-28-apply-media-signaling. This is the only slice in that plan.Issue(s)
https://rocketchat.atlassian.net/browse/VMUX-105
How to test or reproduce
yarn(yarn 1.22.22; npm will not work).cat node_modules/@rocket.chat/media-signaling/package.jsonshows"version": "1.0.0-rc.1"with"license": "MIT"and the GitHub repo URL.resolved "https://registry.yarnpkg.com/@rocket.chat/media-signaling/-/media-signaling-1.0.0-rc.1.tgz#...".yarn lintpasses (0 errors; pre-existing warnings unrelated to this change).TZ=UTC yarn testpasses (148 suites, 1265 tests, 357 snapshots).app/lib/services/voip/MediaCallLogger.test.ts,app/lib/services/voip/parseStringToIceServers.test.ts,app/lib/services/voip/isInActiveVoipCall.test.ts.Screenshots
N/A — packaging change, no UI surface.
Types of changes
Checklist
@rocket.chat/media-signaling@1.0.0-rc.1is published on npm.Further comments
Why
1.0.0-rc.1and not a stable1.0.0?1.0.0-rc.1is the only version of@rocket.chat/media-signalingpublished on the registry as of 2026-04-28. We can move to a stable1.0.0in a separate slice once it ships.This PR is intentionally targeted at
feat.voip-lib-new(notdevelop) because the VoIP feature work the dependency belongs to lives on that branch. PR #7153 (the prior0.2.0tarball bump) was merged intofeat.voip-lib-newfor the same reason.Summary by CodeRabbit