Skip to content

regression: formTextInput clear button not aligned#7269

Merged
OtavioStasiak merged 6 commits into
developfrom
regression.clear-input-button
Apr 30, 2026
Merged

regression: formTextInput clear button not aligned#7269
OtavioStasiak merged 6 commits into
developfrom
regression.clear-input-button

Conversation

@OtavioStasiak

@OtavioStasiak OtavioStasiak commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

FormTextInput Clear button is not aligned, this PR also fixes some issues on iOS e2e tests.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-2153

How to test or reproduce

  • Open the app;
  • Go to a channel;
  • Try to search member;

Screenshots

Before After
Simulator Screenshot - iPhone 16 - 2026-04-30 at 15 56 22 Simulator Screenshot - iPhone 16 - 2026-04-30 at 15 56 55

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Tests

    • Enhanced testing infrastructure with improved test identifiers across components.
    • Added deterministic testing markers for notification displays.
  • Refactor

    • Optimized component structure in form inputs for improved maintainability and clarity.

@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Three components receive testing and layout improvements: DirectoryItem and InAppNotification gain testID attributes on their outer containers for better test identification, while FormTextInput restructures its clear-input button layout to use absolute positioning within a wrapper View.

Changes

Cohort / File(s) Summary
Test ID Propagation
app/containers/DirectoryItem/index.tsx, app/containers/InAppNotification/NotifierComponent.tsx
Adds testID to outer View containers. DirectoryItem propagates testID to the outermost element; InAppNotification adds dynamic testID based on notification text for deterministic test identification.
Layout Refactoring
app/containers/TextInput/FormTextInput.tsx
Restructures the clear-input button rendering: wraps the icon in a View with absolute positioning styles (styles.iconContainer + styles.iconRight) instead of relying on rectButtonStyle-based positioning within the Touch component.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

type: bug

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main change: fixing formTextInput clear button alignment, which is reflected in the primary commit message and the FormTextInput.tsx changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Rohit3523 Rohit3523 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OtavioStasiak OtavioStasiak temporarily deployed to approve_e2e_testing April 30, 2026 15:59 — with GitHub Actions Inactive
@OtavioStasiak OtavioStasiak had a problem deploying to official_android_build April 30, 2026 16:02 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_ios_build April 30, 2026 16:02 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build April 30, 2026 16:02 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak marked this pull request as ready for review April 30, 2026 16:08
@OtavioStasiak OtavioStasiak merged commit fec247a into develop Apr 30, 2026
32 of 40 checks passed
@OtavioStasiak OtavioStasiak deleted the regression.clear-input-button branch April 30, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants