docs: VoIP subsystem documentation#7302
Merged
Merged
Conversation
Add architecture, flows, platform quirks, and runbook docs under app/lib/services/voip/docs/. Three new glossary terms in UBIQUITOUS_LANGUAGE.md (Native Accept, Per-call DDP, Media Signal). Anchor gitignore docs/ rule to repo root so subsystem-level docs/ directories commit normally.
Removed at review — content was speculative and unverified; can be revisited per-failure-mode if and when on-call signal warrants it.
Contributor
|
Caution Review failedFailed to post review comments WalkthroughAdds comprehensive VoIP documentation (architecture, flows with diagrams, platform notes, and README), appends three glossary terms to UBIQUITOUS_LANGUAGE.md, and anchors the docs ignore rule in .gitignore by changing ChangesVoIP documentation & glossary
.gitignore configuration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mermaid sequenceDiagram treats ';' as a statement terminator inside Notes, breaking the diagram-3 closing note. Replace semicolons with em dashes / parentheses so the note renders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds documentation for the VoIP subsystem under
app/lib/services/voip/docs/. Covers architecture, cross-runtime flows, and platform quirks — content that previously lived only in code comments and PR descriptions.Files added:
ARCHITECTURE.md— runtimes, layers, state model, signaling protocol, native bridge contract, invariants.FLOWS.md— six Mermaid sequence diagrams (init/teardown, outgoing, incoming warm/cold, cross-workspace, end call) plus an audio-control-sync subsection.PLATFORMS.md— iOS and Android quirks (PushKit/CallKit, FCM/Telecom, audio routing, manifest andInfo.plist).README.md— index.Also:
UBIQUITOUS_LANGUAGE.md: Native Accept, Per-call DDP, Media Signal.docs/rule to the repo root (/docs/) so subsystem-leveldocs/directories commit normally.Issue(s)
https://rocketchat.atlassian.net/browse/VMUX-111
How to test or reproduce
Open each
.mdin a Markdown preview that supports Mermaid (GitHub PR diff renders Mermaid natively). Verify all six sequence diagrams render and intra-/inter-doc anchor links resolve.Screenshots
n/a — text only.
Types of changes
Checklist
Further comments
Docs only — no source changes, so unit tests are unaffected. Native build paths are not touched.
Summary by CodeRabbit