[NEW] Add prometheus port config#11115
Conversation
[FIX] i18n - add semantic markup
[FIX] Fix spelling of "collaborative"
|
Thai Pham seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
My only problem is this now becomes a breaking change. Because it was released with 9100 already, so if we change the default then when people upgrade it's broken |
I'm OK with not setting a default value of |
|
I've changed the default value of |
|
Can someone please take a look at this change? |
[NEW] Allow the Prometheus port to be configurable
Closes #11114
This also picks a default port number that doesn't conflict with existing allocations from https://github.com/prometheus/prometheus/wiki/Default-port-allocations. Per the recommendation, I use the
9451port, which is available after the one allocated to Habitat Exporter