[FIX] CORS error while interacting with any action button on Livechat#22121
Closed
murtaza98 wants to merge 4 commits into
Closed
[FIX] CORS error while interacting with any action button on Livechat#22121murtaza98 wants to merge 4 commits into
murtaza98 wants to merge 4 commits into
Conversation
KevLehman
reviewed
May 24, 2021
KevLehman
reviewed
May 25, 2021
|
|
||
| const corsOptions = { | ||
| origin: (origin, callback) => { | ||
| if (!origin || (corsEnabled && (allowListOrigins.includes('*') || allowListOrigins.includes(origin))) || origin === settings.get('Site_Url')) { |
Member
There was a problem hiding this comment.
Be aware there's an open PR #22106 that aims to modify Site_Url setting)
Contributor
Author
Member
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed changes (including videos or screenshots)
Duplicate of #21406
PS: Had to close the previous PR because some of the builds were not passing
Issue(s)
#21033
Steps to test or reproduce
Further comments