Skip to content

[FIX] Message box hiding on mobile view (Safari)#22212

Merged
tassoevan merged 6 commits into
developfrom
fix/message-box-hide
Jun 9, 2021
Merged

[FIX] Message box hiding on mobile view (Safari)#22212
tassoevan merged 6 commits into
developfrom
fix/message-box-hide

Conversation

@dougfabris

@dougfabris dougfabris commented Jun 2, 2021

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

before

image

after

image

Issue(s)

Closes #22252

Steps to test or reproduce

  • Open a channel using the safari mobile browser

Further comments

@dougfabris dougfabris requested a review from a team June 2, 2021 00:02
@tassoevan tassoevan added this to the 3.16.0 milestone Jun 8, 2021

@tassoevan tassoevan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a recurrent bug. What about checking if the solution from sanitize.css is better?

:where(body) {
  block-size: -moz-available;
  block-size: -webkit-fill-available;
  block-size: stretch;
}

@dougfabris dougfabris requested a review from tassoevan June 9, 2021 17:35
@dougfabris dougfabris force-pushed the fix/message-box-hide branch from 4d9a221 to 65ac9c3 Compare June 9, 2021 17:36
@tassoevan tassoevan merged commit c594e3d into develop Jun 9, 2021
@tassoevan tassoevan deleted the fix/message-box-hide branch June 9, 2021 20:34
@sampaiodiego sampaiodiego mentioned this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard covers text input

3 participants