Skip to content

[FIX] Sidebar not closing when clicking on a channel#22271

Merged
tassoevan merged 7 commits into
developfrom
fix/sidebar-channel-click
Jun 9, 2021
Merged

[FIX] Sidebar not closing when clicking on a channel#22271
tassoevan merged 7 commits into
developfrom
fix/sidebar-channel-click

Conversation

@dougfabris

@dougfabris dougfabris commented Jun 7, 2021

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

before

before

after

after

Issue(s)

Closes #19755

Steps to test or reproduce

  • change to any room using sidebar on safari mobile

Further comments

@dougfabris dougfabris requested a review from a team June 7, 2021 19:12
@tassoevan tassoevan added this to the 3.16.0 milestone Jun 8, 2021
Comment thread client/sidebar/hooks/useSidebarDisplay.ts Outdated
Comment thread client/sidebar/RoomList/SideBarItemTemplateWithData.js Outdated
@dougfabris dougfabris requested a review from tassoevan June 9, 2021 18:35
Comment thread client/sidebar/hooks/useSidebarDisplay.ts
@dougfabris dougfabris requested a review from tassoevan June 9, 2021 21:01
tassoevan
tassoevan previously approved these changes Jun 9, 2021
@tassoevan tassoevan dismissed their stale review June 9, 2021 21:27

Broken build

Comment thread client/sidebar/RoomList/SideBarItemTemplateWithData.js Outdated
@tassoevan tassoevan merged commit ff5b7fc into develop Jun 9, 2021
@tassoevan tassoevan deleted the fix/sidebar-channel-click branch June 9, 2021 21:59
@dougfabris dougfabris changed the title [FIX] Sidebar not closing after when clicking on a channel [FIX] Sidebar not closing when clicking on a channel Jun 9, 2021
@sampaiodiego sampaiodiego mentioned this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidebar in mobile webapp doesn't automatically close anymore

2 participants