[FIX] Attachments and avatars not rendered if deployed on subfolder#22290
Merged
Conversation
dougfabris
approved these changes
Jun 10, 2021
dougfabris
added
the
stat: ready to merge
Contributor
|
Which release is this expected to go in? |
Member
There is a great probability to be present in the next one, 3.16 |
This was referenced Jun 15, 2021
sampaiodiego
changed the title
sampaiodiego
pushed a commit
that referenced
this pull request
Jun 21, 2021
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
#18759
#19542
Steps to test or reproduce
ROOT_URL=http://localhost:3000/<SUBFOLDER_NAME> meteorPS.: Old quotes will have the avatars broken, since the data from quotes is simply copied instead of referenced. This will only affect servers that CHANGED URL to run on a subfolder
Further comments