Skip to content

[FIX] DeepL supported languages#22326

Merged
geekgonecrazy merged 3 commits into
RocketChat:developfrom
assistify:fix-deepl-supported-languages
Jun 16, 2021
Merged

[FIX] DeepL supported languages#22326
geekgonecrazy merged 3 commits into
RocketChat:developfrom
assistify:fix-deepl-supported-languages

Conversation

@mrsimpson

@mrsimpson mrsimpson commented Jun 11, 2021

Copy link
Copy Markdown
Contributor

Proposed changes

The languages that could be chosen by the user for the provider DeepL have been outdated.
This PR adapts the available languages to the current version of the DeepL API.
The actual API has not changed, it's only the enum of languages supported which has to be coded in the Rocket.Chat client!

@mrsimpson

mrsimpson commented Jun 15, 2021

Copy link
Copy Markdown
Contributor Author

Here's a video to get you convinced that the translation is actually working – with Czech as one of the new languages
https://user-images.githubusercontent.com/17176678/122127577-aca3c500-ce33-11eb-91e1-0ac4376af4a4.mov

Btw: The translation is amazing. How come that DeepL translates the word "Czech" from czech into "English" in english 🤷

@geekgonecrazy geekgonecrazy merged commit 4a28c12 into RocketChat:develop Jun 16, 2021
@sampaiodiego sampaiodiego mentioned this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants