Skip to content

Release 3.16.2#22607

Closed
sampaiodiego wants to merge 4 commits into
masterfrom
release-3.16.2
Closed

Release 3.16.2#22607
sampaiodiego wants to merge 4 commits into
masterfrom
release-3.16.2

Conversation

@sampaiodiego

Copy link
Copy Markdown
Member

2021-07-07 · 3 🐛 · 4 👩‍💻👨‍💻

Engine versions

  • Node: 12.22.1
  • NPM: 6.14.1
  • MongoDB: 3.4, 3.6, 4.0, 4.2
  • Apps-Engine: 1.27.1

🐛 Bug fixes

  • Checks the list of agents if at least one is online (#22584)

  • Error in permission check for getLivechatDepartmentByNameOrId method in Apps (#22545)

    Update the Apps-Engine with a fix for the permission check on the getLivechatDepartmentByNameOrId method

  • Livechat webhook request without headers (#22589)

👩‍💻👨‍💻 Core Team 🤓

@sampaiodiego sampaiodiego requested review from d-gubert, ggazzo and renatobecker and removed request for d-gubert July 7, 2021 14:06
}

findOneOnlineAgentByUsername(username, options) { // TODO:: Create class Agent
findOneOnlineAgentByUserList(userList, options) { // TODO:: Create class Agent

@renatobecker renatobecker Jul 8, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the method findOneOnlineAgentByUsername here and here. Should they be renamed too?

@renatobecker renatobecker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the method findOneOnlineAgentByUsername has not been renamed in all places.

@sampaiodiego

Copy link
Copy Markdown
Member Author

thx @renatobecker good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants