Skip to content

regression: Place unreads on top instead of filter#36754

Merged
ggazzo merged 8 commits into
reg/sidebar-filters-issuesfrom
reg/sidepanel-unread-first
Aug 20, 2025
Merged

regression: Place unreads on top instead of filter#36754
ggazzo merged 8 commits into
reg/sidebar-filters-issuesfrom
reg/sidepanel-unread-first

Conversation

@dougfabris

@dougfabris dougfabris commented Aug 20, 2025

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Introduced here: #36049

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-136

@dionisio-bot

dionisio-bot Bot commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Aug 20, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4835e94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Aug 20, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.88235% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.78%. Comparing base (a7e0a0b) to head (4835e94).
⚠️ Report is 10 commits behind head on reg/sidebar-filters-issues.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           reg/sidebar-filters-issues   #36754      +/-   ##
==============================================================
- Coverage                       65.13%   64.78%   -0.36%     
==============================================================
  Files                            3168     3225      +57     
  Lines                          107871   108086     +215     
  Branches                        20363    20499     +136     
==============================================================
- Hits                            70261    70022     -239     
- Misses                          35050    35543     +493     
+ Partials                         2560     2521      -39     
Flag Coverage Δ
e2e 53.41% <8.82%> (-0.60%) ⬇️
unit 71.25% <60.65%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo marked this pull request as ready for review August 20, 2025 03:56
@ggazzo ggazzo requested a review from a team as a code owner August 20, 2025 03:56
@ggazzo ggazzo merged commit 072bf09 into reg/sidebar-filters-issues Aug 20, 2025
17 checks passed
@ggazzo ggazzo deleted the reg/sidepanel-unread-first branch August 20, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants