fix: imported fixes 03-09-2026#39508
Merged
Merged
Conversation
Co-authored-by: Ricardo Garim <rswarovsky@gmail.com>
🦋 Changeset detectedLatest commit: 8e2f8d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/meteor/app/oauth2-server-config/server/oauth/oauth2-server.ts">
<violation number="1" location="apps/meteor/app/oauth2-server-config/server/oauth/oauth2-server.ts:78">
P2: Avoid casting `routeContext.queryParams` to `Record<string, unknown>` for deletion; use the already narrowed `query` object instead.
(Based on your team's feedback about avoiding unsafe type casts to silence TypeScript errors.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.2.1 #39508 +/- ##
=================================================
- Coverage 70.59% 70.49% -0.10%
=================================================
Files 3188 3188
Lines 112623 112625 +2
Branches 20402 20434 +32
=================================================
- Hits 79503 79393 -110
- Misses 31068 31173 +105
- Partials 2052 2059 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ricardogarim
approved these changes
Mar 11, 2026
ricardogarim
added
the
stat: QA assured
Merged
ggazzo
pushed a commit
that referenced
this pull request
Mar 25, 2026
Co-authored-by: Yasmim Nagat <117310290+yasnagat@users.noreply.github.com> Co-authored-by: Ricardo Garim <rswarovsky@gmail.com> Co-authored-by: Julio Araujo <julio.araujo@rocket.chat>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #39492