converted slashcommand-leave coffee to js#6470
Merged
Merged
Conversation
rodrigok
requested changes
Mar 28, 2017
Member
There was a problem hiding this comment.
Why did you change undefined to null?
Member
Author
There was a problem hiding this comment.
because in this case, there are no difference.
the test is RocketChat.slashCommands.commands[command]?.callback? it will test callback != null;
, but I can change if you prefer.
Contributor
There was a problem hiding this comment.
To me undefined reads and is more "javascripty" than null, so I would personally prefer undefined.
Member
There was a problem hiding this comment.
Why declare a variable if you are naming a function?
Member
There was a problem hiding this comment.
If you invert a condition you need to invert the conditionals too:
if(command == "leave" || command == "part")
continue
Should be:
if (command !== 'leave' && command !== 'part') {
return
In your conde command part will execute the return cuz it's different from leave
ggazzo
force-pushed
the
slashcommands-leave
branch
from
e7e962c to
0b180a8
Compare
rodrigok
approved these changes
Mar 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core