rocketchat-lib part1 by ggazzo · Pull Request #6553 · RocketChat/Rocket.Chat

ggazzo · 2017-03-31T19:00:43Z

No description provided.

rodrigok · 2017-03-31T21:57:51Z

@@ -0,0 +1,19 @@
+/* globals LoggerManager */
+RocketChat.settings.get('Log_Package', function(key, value) {
+	return (typeof LoggerManager !== 'undefined') && LoggerManager !== null && (LoggerManager.showPackage = value);


Simplify to LoggerManager && LoggerManager.showPackage = value;

actually, if the variable LoggerManager have never been declared, It will throw an exception

LoggerManager && LoggerManager.showPackage = value; // Uncaught ReferenceError: LoggerManager is not defined

typeof LoggerManager != 'undefined' && LoggerManager.showPackage = value; // nothing happens

rodrigok · 2017-03-31T21:58:08Z

+});
+
+RocketChat.settings.get('Log_File', function(key, value) {
+	return typeof LoggerManager !== 'undefined' && LoggerManager !== null && (LoggerManager.showFileAndLine = value);


rodrigok · 2017-03-31T21:58:42Z

+
+RocketChat.settings.get('Log_Level', function(key, value) {
+	if (value != null) {
+		if (typeof LoggerManager !== 'undefined' && LoggerManager !== null) {


Simplify to LoggerManager != null

rodrigok · 2017-03-31T21:59:06Z

+			LoggerManager.logLevel = parseInt(value);
+		}
+		Meteor.setTimeout(() => {
+			return typeof LoggerManager !== 'undefined' && LoggerManager !== null && LoggerManager.enable(true);


rodrigok · 2017-03-31T21:59:54Z

@@ -0,0 +1,8 @@
+


Where is the .coffee file?

rodrigok · 2017-03-31T22:07:39Z

@@ -0,0 +1,1006 @@
+RocketChat.settings.add('uniqueID', process.env.DEPLOYMENT_ID || Random.id(), {


Can you keep the comments?

rodrigok · 2017-03-31T22:07:47Z

+	hidden: true
+});
+
+RocketChat.settings.addGroup('Accounts', function() {


Can you keep the comments?

rodrigok · 2017-03-31T22:10:00Z

+/* globals WebAppInternals*/
+RocketChat.settings.onload('CDN_PREFIX', function(key, value) {
+	if (_.isString(value || false)) {
+		return typeof WebAppInternals !== 'undefined' && WebAppInternals !== null && WebAppInternals.setBundledJsCssPrefix(value);


Simplify this line

rodrigok · 2017-03-31T22:12:07Z

+
+Meteor.startup(function() {
+	const value = RocketChat.settings.get('CDN_PREFIX');
+	if (_.isString(value || false)) {


Any string value will be considered true?

My wish was testing if the variable is a string or it is not an empty string.

"asda"||false - > "asda"

""||false - > false

because _.isString("") === true

Ok, but that looks strange and will allow spaces. What about if (_.isString(value) && value.trim()) just to be more clear?

rodrigok · 2017-03-31T22:12:18Z

+Meteor.startup(function() {
+	const value = RocketChat.settings.get('CDN_PREFIX');
+	if (_.isString(value || false)) {
+		return typeof WebAppInternals !== 'undefined' && WebAppInternals !== null && WebAppInternals.setBundledJsCssPrefix(value);


Simplify this line

rodrigok · 2017-04-03T19:49:38Z

+
 RocketChat.settings.get('Log_Package', function(key, value) {
-	return (typeof LoggerManager !== 'undefined') && LoggerManager !== null && (LoggerManager.showPackage = value);
+	return log(LoggerManager => LoggerManager.showPackage = value);


Why not LoggerManager && LoggerManager.showPackage = value?

rodrigok · 2017-04-03T19:50:43Z

 RocketChat.settings.onload('CDN_PREFIX', function(key, value) {
 	if (_.isString(value || false)) {
-		return typeof WebAppInternals !== 'undefined' && WebAppInternals !== null && WebAppInternals.setBundledJsCssPrefix(value);
+		return testWebAppInternals(WebAppInternals => WebAppInternals.setBundledJsCssPrefix(value));


Why not WebAppInternals && WebAppInternals.setBundledJsCssPrefix(value)?

rodrigok · 2017-04-04T11:25:52Z

@ggazzo Can you fix the conflicts?

ggazzo · 2017-04-04T13:28:46Z

yes, I can.

…nto rocketchat-lib

conversion coffee js

ab1011d

ggazzo added the type: coffee2js label Mar 31, 2017

rodrigok requested changes Mar 31, 2017

View reviewed changes

fix review

ca5c7e5

rodrigok approved these changes Apr 3, 2017

View reviewed changes

rodrigok added this to the 0.55.0 milestone Apr 3, 2017

ggazzo added 2 commits April 4, 2017 10:38

Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…

d0f48f8

…nto rocketchat-lib

fix review

e6b5831

rodrigok approved these changes Apr 4, 2017

View reviewed changes

rodrigok added the Ready to Merge label Apr 4, 2017

engelgabriel merged commit 413ac7a into RocketChat:develop Apr 4, 2017

ggazzo deleted the rocketchat-lib branch April 4, 2017 18:23

sampaiodiego mentioned this pull request Apr 4, 2017

Only configure LoggerManager on server #6596

Merged

		@@ -0,0 +1,1006 @@
		RocketChat.settings.add('uniqueID', process.env.DEPLOYMENT_ID \|\| Random.id(), {

Uh oh!

Conversation

ggazzo commented Mar 31, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rodrigok commented Apr 4, 2017

Uh oh!

ggazzo commented Apr 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants