[FIX] Incorrect error message when creating channel#6747
Merged
rodrigok merged 1 commit intoApr 24, 2017
Merged
Conversation
rodrigok
approved these changes
Apr 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #6711
The validation method wasn't being able to find the actual label for the inputs since it was changed from 'label' to 'span' in the html in a previous commit. So I rolled back the label versions since, in my opinion, it makes more sense than having the 'span's there. Changed the css selector as well and removed some console logging.
Message when trying to create a channel with empty name:
