[FIX] Added helper for testing if the current user matches the params#6845
Merged
Conversation
Updated users.getPresence and users.setAvatar REST APIs to use current user param helper
graywolf336
reviewed
May 1, 2017
|
|
||
| RocketChat.API.v1.addRoute('users.getPresence', { authRequired: true }, { | ||
| get() { | ||
| //BLAHHHHHHHHHH :'( |
Contributor
There was a problem hiding this comment.
Ahhhhhh so nice to have this removed ;)
graywolf336
approved these changes
May 1, 2017
graywolf336
left a comment
graywolf336
left a comment
Contributor
There was a problem hiding this comment.
Thank for you for these changes, makes it all much cleaner and easier to use!
Do you mind updating the documentation to go along with this? If not, I will add it to my list and get it changed in the docs.
Contributor
Author
|
Yep no problem. I'll send through a PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
users.getPresenceto use current user param matcherusers.setAvatarto supportusernameparameter