[FIX] Remove room from roomPick setting#6912
Merged
Merged
Conversation
sampaiodiego
previously requested changes
May 8, 2017
sampaiodiego
left a comment
sampaiodiego
left a comment
Member
There was a problem hiding this comment.
The behavior still looks odd to me:
- I cannot save after using the "reset setting" button
- After removing a selected room the "Cancel" button does not clear the "changed" state
Member
|
Also it conflicts with #6911 .. Maybe it should be easier to merge the conversion first. |
Member
Author
|
Cool! I made the requested changes and will wait until #6911 is merged to fix conflicts. |
# Conflicts: # packages/rocketchat-ui-admin/client/admin.coffee
Use property shorthand
Use const instead of let
…et.Chat into remove-room-from-setting
rodrigok
approved these changes
May 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #6646