Skip to content

[FIX] Not showing unread count on electron app’s icon#6923

Merged
engelgabriel merged 1 commit into
release-candidatefrom
hotfix/rc-electron-unread-badge
May 9, 2017
Merged

[FIX] Not showing unread count on electron app’s icon#6923
engelgabriel merged 1 commit into
release-candidatefrom
hotfix/rc-electron-unread-badge

Conversation

@rodrigok

@rodrigok rodrigok commented May 9, 2017

Copy link
Copy Markdown
Member

@RocketChat/core

Close #6900

@rodrigok rodrigok added this to the 0.56.0 milestone May 9, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6923 May 9, 2017 18:35 Inactive
@sampaiodiego

sampaiodiego commented May 9, 2017

Copy link
Copy Markdown
Member

should we add a comment on that line describing what it does so people like me don't mess with it again? 😬

@sampaiodiego sampaiodiego reopened this May 9, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6923 May 9, 2017 18:39 Inactive
@engelgabriel engelgabriel requested a review from sampaiodiego May 9, 2017 19:06
@engelgabriel engelgabriel merged commit 48efadb into release-candidate May 9, 2017
@engelgabriel engelgabriel deleted the hotfix/rc-electron-unread-badge branch May 9, 2017 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants