changing username by admin#699
Merged
Merged
Conversation
Contributor
|
This also looks solid. Going to test both this and #696. The underlying method hasn't been tested fully. |
Member
|
Guys, update the username is not that simple. You need to use the method. There are a lot of checking and references that need o be updated together, not just the users collection. |
Member
|
Need to call /packages/rocketchat-lib/server/methods/setUsername.coffee |
Contributor
Author
|
Updated so the update method is only called once. New to meteor, didn't realise that was possible. Thanks! |
Member
|
I think this should be done, but using the right method call |
…od to ensure it's the correct user
Contributor
Author
|
@engelgabriel fixed to use the setUsername method. |
engelgabriel
added a commit
that referenced
this pull request
Sep 7, 2015
changing username by admin
This was referenced Feb 1, 2020
This was referenced Apr 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #698