[FIX] New screen sharing Chrome extension checking method#7044
Merged
Conversation
Try to communicate with Chrome extension to see it is installed instead of checking for a cookie (the Chrome extension will not set a cookie anymore)
Member
|
Is this working on electron? |
Member
|
@sampaiodiego did you test on Electron? |
Contributor
|
@rodrigok unless i'm missing something I don't think screensharing has ever worked in electron. The extension isnt baked in unless this is a recent change? |
Member
Author
|
@rodrigok @engelgabriel as you can see on the previous code, it skips the extension checks if you're on electron (by explicitying doing |
Member
|
True 😄 |
rodrigok
approved these changes
May 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to communicate with Chrome extension to see it is installed instead of checking for a cookie (the Chrome extension will not set a cookie anymore).
Chrome extension version 0.3+ accepts this method.
@RocketChat/core