Skip to content

[FIX] Send email to admins when user need to be approved to join#7090

Closed
luisfn wants to merge 4 commits into
developfrom
issue_976
Closed

[FIX] Send email to admins when user need to be approved to join#7090
luisfn wants to merge 4 commits into
developfrom
issue_976

Conversation

@luisfn

@luisfn luisfn commented May 25, 2017

Copy link
Copy Markdown
Contributor

@RocketChat/core

Closes #976

The idea is to send a simple email to all admin users when an user register and needs approval to join.

image

image

image

@CLAassistant

CLAassistant commented May 25, 2017

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7090 May 25, 2017 12:29 Inactive
@luisfn luisfn changed the title [FIX] 976 [FIX] Send email to admins when user need to be approved to join May 25, 2017
Comment thread server/lib/accounts.js
subject: Accounts.emailTemplates.notifyAdmin.subject(),
html: Accounts.emailTemplates.notifyAdmin.html(user)
};

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of sending an e-mail for each of the admins, I'd make a list of admin emails and send only one e-mail with everyone on it.

One of the advantages to this is knowing who are the other admins that received that email and might have acted on it before you do.

@engelgabriel engelgabriel added this to the 0.57.0 milestone May 25, 2017
@luisfn luisfn closed this May 26, 2017
@frdmn

frdmn commented May 29, 2017

Copy link
Copy Markdown
Contributor

@luisfn This looked pretty awesome, why did you close?

@geekgonecrazy

Copy link
Copy Markdown
Contributor

@frdmn looks like moved here: #7098

@luisfn

luisfn commented May 29, 2017

Copy link
Copy Markdown
Contributor Author

Yes, I moved to #7098. Hope it's in the right path

@frdmn

frdmn commented May 29, 2017

Copy link
Copy Markdown
Contributor

@luisfn @geekgonecrazy 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants