[NEW] Global announcement#8461
Conversation
…ignment [FIX] message actions over unread bar
[FIX] popover position on mobile
* Fix hyperlink style on sidebar footer * fix a selector
[FIX] search results position on sidebar
…ents [FIX] sidebar paddings
…ow-rocketDebug [FIX] Window exception when parsing Markdown on server
Hide flex-tab close button
…e-api-notifications [FIX] Remove break change in Realtime API
[FIX] Fix livechat toggle UI issue
[FIX] Fix google play logo on repo README
…irst-load [FIX] Show leader on first load
[DOCS] Add native mobile app links into README and update button images
[FIX] Create channel button on Firefox
[FIX] Broken emoji picker on firefox
…placeholders [FIX] Fix placeholders in account profile
[FIX] Document README.md. Drupal repo out of date
[FIX] username ellipsis on firefox
[FIX] OTR buttons padding
[FIX] status and active room colors on sidebar
…list [FIX] Fix the status on the members list
…de-render [FIX] Markdown being rendered in code tags
[FIX] Small alignment fixes
[FIX] Sidebar item menu position in RTL
…port [FIX] Slack import failing and not being able to be restarted
[FIX] Add needed dependency for snaps
…reconnect Fix: Missing LDAP reconnect setting
…internal-log-level Fix: Missing LDAP option to show internal logs
Fix: Account menu position on RTL
- Configurable global announcement via settings - Uses theme "attention-color" for styling (don't complain to me with respect to the default colors!) - Appears on Login, Home and Channel-Screens - Can be confirmed if a user is logged-in - Button floats which allows long and short texts
|
Ok this is awesome!! I like this UI much better then our current per channel announcement as well. @rocketchat/core this would also be useful on our community server for announcements. I'm sure useful to many others |
|
@geekgonecrazy glad you like it. One thing which isn’t amazing is that the announcement re-appears after confirmation once the server restarts (e. G. Due to a new deployment). The reason for that is that I’m using the lastUpdated impaired to the readConfirmation timestamp in order to determine whether the announcement shall appear. Currently, lastUpdated is getting updated on startup though. I consider this a bug, wdyt? |
|
Finally!!! This is a long-time needed feature. Thanks so much for implementing it. |
|
@mrsimpson I'd agree most would consider this a bug. But not a show stopper for this PR in my opinion |
…l-announcement # Conflicts: # .snapcraft/snapcraft.yaml # README.md # packages/rocketchat-api/server/v1/channels.js # packages/rocketchat-api/server/v1/groups.js # packages/rocketchat-google-vision/.npm/package/npm-shrinkwrap.json # packages/rocketchat-i18n/i18n/de.i18n.json # packages/rocketchat-i18n/i18n/en.i18n.json # packages/rocketchat-ldap/server/ldap.js # packages/rocketchat-ldap/server/sync.js # packages/rocketchat-markdown/tests/client.tests.js # packages/rocketchat-theme/client/imports/components/messages.css # packages/rocketchat-theme/client/imports/components/popover.css # packages/rocketchat-theme/client/imports/components/sidebar/sidebar.css # packages/rocketchat-theme/client/imports/general/base.css # packages/rocketchat-theme/client/imports/general/base_old.css # packages/rocketchat-theme/client/imports/general/variables.css # packages/rocketchat-ui/client/lib/chatMessages.js # packages/rocketchat-ui/client/views/app/popover.js # packages/rocketchat-ui/client/views/app/room.js # server/publications/room.js
No idea why git didn't overwrite them earlier.
mrsimpson
left a comment
mrsimpson
left a comment
There was a problem hiding this comment.
Just merged the latest develop` and manually removed differences which remained to to other branch-off.
| return this.update(query, update); | ||
| } | ||
|
|
||
| confirmGlobalAnnouncementRead(_id) { |
There was a problem hiding this comment.
this actually is the only part which really changed in this file. The rest is only pretty printing.
| } | ||
|
|
||
| /* on Login-screen */ | ||
| .wrapper .global-announcement { |
There was a problem hiding this comment.
maybe, dedicated classes should be used. However, I wanted to modify as least as possible
| const settingGlobalAnnouncement = RocketChat.models.Settings.findOne({_id: 'Layout_Global_Announcement'}); | ||
| const user = RocketChat.models.Users.findOne({_id: Meteor.userId()}); | ||
|
|
||
| return !!user.globalAnnouncementRead && (user.globalAnnouncementRead > settingGlobalAnnouncement._updatedAt); |
There was a problem hiding this comment.
@geekgonecrazy comparing with _updatedAt has the flaw of making the annoucement re-appear on server startup.
If the settings were not upserted on add(), but only if the value set differs, this would not be the case anymore.
There was a problem hiding this comment.
I think this is ok for merging. Maybe we should take a look at modding that behavior though..
|
@karlprieb a good bit of UI stuff here. Can you take a quick peek? :) |
|
We had a PR come along after yours: #9778 I think does the same. I'm guessing when we went to create we didn't search for announcement. Also ours doesn't reach as far as yours.... @rodrigok @karlprieb what do we want to do? |
|
I think we should close this PR and extend #9778 |
|
@mrsimpson as mentioned above we implemented one to handle version alert. It's very similiar but is a banner across the entire top. Maybe we could extend that? |
|
I’m always happy to delete Code I wrote - reduces maintenance effort. It shouldn’t be a big deal to extend the general alert banner.
If @karlprieb was handling this, that would be great. Sent with GitHawk |
9 participants
@RocketChat/core Forked off 0.59.0-rc12
Motivation
Closes RocketChat/feature-requests#606
Remarks
Don't complain to me with respect to the default colors!
I applied all of my non-existent css-skills to it - if you've got suggestions, shoot!
This is how it looks like
Short texts
Longer texts
Configuration
"Mobile"
On very small displays (mobile), it hides the burger button. However, I do not think that this is a problem. If you (RC) consider it wrong, kindly help me out on the CSS ;)
Feedback (and of course merging) appreciated