Skip to content

[Fix] closing user being transmitted in close by visitor#9698

Closed
mrsimpson wants to merge 1 commit into
RocketChat:developfrom
assistify:core/#9673-close-livechat-by-visitor
Closed

[Fix] closing user being transmitted in close by visitor#9698
mrsimpson wants to merge 1 commit into
RocketChat:developfrom
assistify:core/#9673-close-livechat-by-visitor

Conversation

@mrsimpson

@mrsimpson mrsimpson commented Feb 13, 2018

Copy link
Copy Markdown
Contributor

@RocketChat/core

Closes #9558

This fixes a "syntax error" violating the closeRoom method signature.

@sampaiodiego: is it semantically correct to pass Meteor.user() as closing use or should this also be the visitor

@sampaiodiego

Copy link
Copy Markdown
Member

is it semantically correct to pass Meteor.user() as closing use or should this also be the visitor

nope. unfortunately there is no Meteor.user() when visitor calls it.. this should not fix the issue

@renatobecker-zz

renatobecker-zz commented Feb 14, 2018

Copy link
Copy Markdown

We are closing this PR because we are going to fix this issue unifying some methods that are still using the user property internally.
As a visitor is not a logged user, the Meteor.user() can't be passed to internal method.
After this fix, the user property will no longer be used.

Anyway, thanks for your effort and help.

@ruKurz

ruKurz commented Feb 14, 2018

Copy link
Copy Markdown
Contributor

As far I can see this PR is closed by #9714

@mrsimpson mrsimpson deleted the core/#9673-close-livechat-by-visitor branch December 7, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

End livechat session

4 participants