[Fix] closing user being transmitted in close by visitor#9698
Closed
mrsimpson wants to merge 1 commit into
Closed
Conversation
Member
nope. unfortunately there is no |
|
We are closing this PR because we are going to fix this issue unifying some methods that are still using the Anyway, thanks for your effort and help. |
Contributor
|
As far I can see this PR is closed by #9714 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9558
This fixes a "syntax error" violating the
closeRoommethod signature.@sampaiodiego: is it semantically correct to pass
Meteor.user()as closing use or should this also be thevisitor