Skip to content
This repository was archived by the owner on Mar 17, 2023. It is now read-only.

[FIX] Fix docs about chat.react endpoint, add parameter to endpoint#693

Merged
engelgabriel merged 3 commits into
masterfrom
fix-rest-chat-react
Apr 30, 2018
Merged

[FIX] Fix docs about chat.react endpoint, add parameter to endpoint#693
engelgabriel merged 3 commits into
masterfrom
fix-rest-chat-react

Conversation

@MarcosSpessatto

Copy link
Copy Markdown

Fix docs about chat.react endpoint, add parameter to endpoint to make endpoint work like a toggle.
Waiting PR.

Fix docs about chat.react endpoint, add parameter to endpoint

@cardoso cardoso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with the API @MarcosSpessatto

I think we can explain this better:

| :--- | :--- | :--- | :--- |
| `emoji` | `smile` | Required | The emoji to react with. |
| `messageId` | `7aDSXtjMA3KPLxLjt` | Required | The message id to react to. |
| `shouldReact` | `7aDSXtjMA3KPLxLjt` | Optional: `true` or `false` | Parameter to make endpoint work like a toggle. |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way it worked before was like a toggle. "shouldReact" makes it work like a setter.

I think it would be better explained this way:

Parameter to specify if the reaction should be added or removed


| Version | Description |
| :--- | :--- |
| 0.64.0 | Added parameter "shouldReact" to make endpoint work like a toggle |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work like a setter

Marcos Defendi and others added 2 commits April 17, 2018 15:52
Fix the explanation about chat.react ednpoint
@engelgabriel engelgabriel merged commit 19a0b1b into master Apr 30, 2018
@engelgabriel engelgabriel deleted the fix-rest-chat-react branch April 30, 2018 01:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants