DOC: update README.md with new features of v1.0.0a1.#388
Merged
phmbressan merged 3 commits intobeta/v1.0.0from Jul 1, 2023
Merged
DOC: update README.md with new features of v1.0.0a1.#388phmbressan merged 3 commits intobeta/v1.0.0from
phmbressan merged 3 commits intobeta/v1.0.0from
Conversation
| If you want to see the trajectory on Google Earth, RocketPy acn easily export a KML file for you: | ||
|
|
||
| ```python | ||
| test_flight.export_kml(file_name="test_flight.kml") |
Member
There was a problem hiding this comment.
I will give a candy to whoever adds a good picture of trajectory plotted on Google Earth
extra candy if it is a GIF
Gui-FernandesBR
approved these changes
Jul 1, 2023
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Well done, @phmbressan !!
I updated a few things in the file. Please check it and merge whenever you want.
Could you please confirm that the simulation steps (given in the README) work on your machine?
Ty again!
7 tasks
Collaborator
Author
|
The README.md simulations are working correctly here, I will merge this PR, but we ought to remember to update the diagrams in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
ReadMe, Docs and GitHub maintenance:
What is the current behavior?
Documentation was out of date regarding features of
v1.0.0a1.What is the new behavior?
Readme.md was updated with essential info regarding
HybridMotorandLiquidMotor.Does this introduce a breaking change?