TST: new set of tests to the Flight class#408
Merged
Gui-FernandesBR merged 12 commits intodevelopfrom Nov 3, 2023
Merged
Conversation
Member
Author
|
And of course it didn't work out of windows system (great!!) I'm converting this to draft, temporarily |
phmbressan
reviewed
Sep 12, 2023
Gui-FernandesBR
commented
Sep 13, 2023
Base automatically changed from
bug/max-button-forces-values
to
beta/v1.0.0
September 15, 2023 23:38
Gui-FernandesBR
commented
Oct 29, 2023
Member
Author
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Merging the develop branch into this one actually solved the problem that was blocking this PR.
So I believe we are good to go!
I can't merge it bc we need an approval first. Asking for help here.
phmbressan
approved these changes
Oct 29, 2023
Collaborator
phmbressan
left a comment
There was a problem hiding this comment.
Good. I have updated some old docstrings in my latest commits.
Before merging, I would only double check if the numbers of the new tests are still valid (the ones that come from sim results) since there was a gap of time between this PR being implmented and now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
Code base additions (for bug fixes / features):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information
beta/v1.0.0