Airfoil implementation#47
Merged
giovaniceotto merged 5 commits intoRocketPy-Team:masterfrom Oct 3, 2020
Merged
Conversation
Fork Update
The commit brings the implementation to use airfoiled fins simulation using a .csv file as input for the lift coefficient. At flight, two minor changes were made. The first was to move the access to lift coefficient at Flight class to the end because Udot function initializes without the compAttackAngle variable. Lift force calculus were also changed because cLift is the lift coefficient and not the lift coefficient derivative anymore (the name were also changed). At Rocket class there were major changes. addNonecone, addTail and AddFins don’t return a derivative anymore at aerodynamicSurfaces[1][1]. Now, at the position, an object of Function class is returned instead with the function that describes the component’s lift by attack angle. At nosecone and tail, it is a linear function with derivative clalpha. At fins, it either be a linear function using previous implementation of clalpha, or be a function of the .csv input linearly interpolated. Minor changes at evaluateStaticMargin and allInfo were also made to make those functions compatible with the new lift coefficient implementation.
pseudoD calculation was accidentally altered, but now is equal to the previous implementation.
giovaniceotto
requested changes
Sep 23, 2020
The variable was accidentally stored at Rocket class twice. It can already be found at aerodynamicSurfaces, besides it only stored the value of last component added.
brunosorban
commented
Sep 24, 2020
| Returns | ||
| ------- | ||
| cldata : Function | ||
| Object of the Function class. Contains tail's lift data. |
Collaborator
Author
There was a problem hiding this comment.
Now the cldata isn't stored anymore, should I remove it from Returns?
There was a mistake in the way the Normal force coefficient were being calculated. Now it considers the input of a 2D airfoil data and calculates the 3D parameters to the fins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit brings the implementation to use airfoiled fins simulation using a .csv file as input for the lift coefficient. At Flight, two minor changes were made. The first was to move the access to lift coefficient at Flight class to the end because Udot() function initializes without the compAttackAngle variable. Lift force calculus were also changed because cLift is the lift coefficient and not the lift coefficient derivative anymore (the name were also changed).
At Rocket class there are major changes. addNonecone(), addTail() and AddFins() don’t return a derivative anymore at aerodynamicSurfaces[1][1]. Now, at the position, an object of Function class is returned instead with a function that describes the component’s lift by attack angle. At nosecone and tail, it is a linear function with derivative clalpha. At fins, it either be a linear function using previous implementation of clalpha, or be a function of the .csv input linearly interpolated. Minor changes at evaluateStaticMargin() and allInfo() were also made to make those functions compatible with the new lift coefficient implementation.