Merged
Conversation
DOC: Add RocketPy change log file
HOTFIX: Negative Static Margin
HOTFIX: 2D .CSV Function and missing set_get_value_opt call
HOTFIX: Tanks Overfill not Being Detected
Gui-FernandesBR
requested changes
Nov 23, 2023
Member
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Thank you @MateusStano !!
2 changes that we still need to do before merging:
- Update the CHANGELOG file.
- Re-run the SEBLM notebook to update the static margin plot. See:
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 70.80% 70.89% +0.08%
==========================================
Files 55 55
Lines 9234 9258 +24
==========================================
+ Hits 6538 6563 +25
+ Misses 2696 2695 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
We should have more tests for the tanks, not all the lines are being covered right now, as reported by the codecov |
Member
|
This one solves #482 |
ENH: Prevent out of bounds Tanks from Instantiation
phmbressan
approved these changes
Nov 24, 2023
Collaborator
phmbressan
left a comment
There was a problem hiding this comment.
Great fixes. I just noticed a small assertion mistake and will commit a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixed
#479:
#478:
#476: