-
-
Notifications
You must be signed in to change notification settings - Fork 250
ENH: Tank Fluids with Variable Density from Temperature and Pressure #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4c2d8b0
ENH: add time variable density to Tank Fluids.
phmbressan 6ca3bdc
TST: add tests for variable fluid density.
phmbressan 1352a4d
STY: running isort for import order consistency.
phmbressan 8be8859
DOC: update Fluid docs with variable density explanations.
phmbressan e468f88
MNT: use Union is Fluid dataclass type for Python <3.10 support.
phmbressan 82d2d7b
ENH: add time variable density to Tank Fluids.
phmbressan a4cb1d4
STY: running isort for import order consistency.
phmbressan d42acab
MNT: use Union is Fluid dataclass type for Python <3.10 support.
phmbressan e4766b6
MNT: refactor density variation for temperature and pressure inputs.
phmbressan 11f5bc6
MNT: improve Tank class outputs (WIP).
phmbressan 72d2541
DOC: update fluid density documentation.
phmbressan 5fdd5a4
MNT: Add CAD data for tank geometry validation.
phmbressan 979692e
MNT: Refactor tank testing and improve file structure.
phmbressan af774d3
MNT: add recent changes to CHANGELOG.
phmbressan 15c2225
MNT: post merge fixes from testing refactors.
phmbressan 8788997
MNT: post rebase fixes.
phmbressan 57f0124
TST: introduce testing to variable density tanks.
phmbressan 1d09834
MNT: Add recent changes to CHANGELOG.
phmbressan 568661d
TST: improve fluid tests and solve review comments.
phmbressan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ENH: add time variable density to Tank Fluids.
- Loading branch information
commit 82d2d7b30bf024e42b9dd4fb103ff5d9bfe2a16a
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.