Fix parallel Monte Carlo simulation showing incorrect iteration count#885
Merged
Gui-FernandesBR merged 2 commits intodevelopfrom Nov 27, 2025
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix incorrect iteration output in parallel Monte Carlo simulation
Fix parallel Monte Carlo simulation showing incorrect iteration count
Nov 27, 2025
Member
|
@copilot don't forget to include this PR in the CHANGELOG.md file! Keep the same formatting please. |
Contributor
Author
Gui-FernandesBR
approved these changes
Nov 27, 2025
Member
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
It would be nice to test it before closing the associated issue
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #885 +/- ##
===========================================
+ Coverage 80.27% 80.35% +0.08%
===========================================
Files 104 106 +2
Lines 12769 13010 +241
===========================================
+ Hits 10250 10454 +204
- Misses 2519 2556 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…y increasing completed count Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
8d3e803 to
7cfc5a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sim_idxis passed directly, but simulations complete out of ordercompleted_countcounter to_SimMonitorclass to track completed simulationsprint_update_status()method to usecompleted_countinstead ofsim_idxand change label from "Current iteration" to "Iterations completed"completed_countin the method when called (since it's always called within mutex-protected section)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.