Fix deprecation warning under Ruby 2.2.0#470
Merged
Merged
Conversation
* Arithmetic#== was not being used, Comparable#== was instead, so it was using <=> for comparison but swallowing any exceptions * Fixes #469
semmons99
added a commit
that referenced
this pull request
Dec 27, 2014
Fix deprecation warning under Ruby 2.2.0
This was referenced Jun 17, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using <=> for comparison but swallowing any exceptions
This changes the behavior of == if you have exchange set up, so maybe this should only go into a new major release to keep semantic versioning?