Return nil when currency cannot be converted for comparison#549
Merged
semmons99 merged 1 commit intoAug 27, 2015
Conversation
- In the next Ruby release #== will no longer rescue exceptions and expects #<=> to return nil if the comparison is inappropriate - Comparable#== will not rescue exceptions of #<=> in the next release
semmons99
added a commit
that referenced
this pull request
Aug 27, 2015
Return nil when currency cannot be converted for comparison
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the future Ruby releases
#==will no longer rescue exceptions and expects#<=>to returnnilif the comparison is inappropriate (because in Money#==is provided by Comparable)I know this has come up in a couple of times before but Ruby is complaining louder in spec output now (because some specs should be breaking and raising
Money::Bank::UnknownRate).I guess this follows on from work done in #528