feat: add spell check setting for input areas#729
Conversation
Add a new `spellCheck` boolean setting (default: off) that enables browser-native spell checking across all text input areas including the main prompt input, group chat input, file editor, and mobile command input bar. Closes #253
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughA new spell check feature is introduced, allowing users to toggle browser spell checking for text input areas across the application. The setting is added to the defaults and types, wired through the settings store and hooks, integrated into input components, and exposed via a toggle in the General settings tab. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
docs/releases.md (1)
439-448: Use consistent Markdown bullets for reliable rendering.These sections use
•while the rest of the file uses-. Prefer a single bullet style across release notes.Proposed fix pattern
-• Enhanced mobile web interface with session sync and history panel 📱 +- Enhanced mobile web interface with session sync and history panel 📱Apply the same replacement for the remaining
•items in these ranges.Also applies to: 462-471
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/releases.md` around lines 439 - 448, Replace the unicode bullet characters ("•") in docs/releases.md with the standard Markdown dash "-" to ensure consistent rendering; search for the listed entries (e.g., lines containing "Enhanced mobile web interface with session sync and history panel", "Added ThinkingStatusPill showing real-time token counts and elapsed time", etc.) and replace each leading "•" with "-" and apply the same replacement for the other affected ranges (notably the section also mentioned around lines 462-471).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/releases.md`:
- Line 74: Fix the typos and wording in the release notes: change "FIle" to
"File" in the "🗄️ Document Graphs." line, replace "built in" with "built-in",
correct "will received" to "will receive", and change "Github" to "GitHub";
apply the same corrections to the other occurrences noted (lines referenced as
149, 153, 174) so all instances in docs/releases.md use the proper
capitalization and hyphenation.
- Line 20: Update the heading level for in-section titles like "Major 0.15.x
Additions" in docs/releases.md so they are subsection headings (e.g., convert
leading '#' to '###') rather than top-level H1; ensure all similar headings
mentioned (the ones at the other occurrences in this file) are changed
consistently so the document outline/TOC remains hierarchical and navigation
works correctly.
- Line 80: Update the incorrect heading string "# Smaller Changes in 014.x" to
"# Smaller Changes in 0.14.x" so the version label is correct; locate the
heading line containing "Smaller Changes in 014.x" and replace "014.x" with
"0.14.x" to fix the typo.
In `@src/prompts/maestro-system-prompt.md`:
- Line 48: The scanner currently recurses without limits; update scanDirectory
and checkForMarkdownFiles to enforce a maximum subdirectory depth of 1 under the
AUTORUN_FOLDER for multi-phase efforts: add a depth (or relativeDepth) parameter
to scanDirectory and only recurse when depth < 1, and in checkForMarkdownFiles
compute the path depth relative to AUTORUN_FOLDER and either reject (throw/log
an error) or skip any markdown files found at depth > 1; ensure error messages
reference the offending path and the rule (single-level YYYY-MM-DD-Feature-Name
folder) so callers can surface the validation failure.
---
Nitpick comments:
In `@docs/releases.md`:
- Around line 439-448: Replace the unicode bullet characters ("•") in
docs/releases.md with the standard Markdown dash "-" to ensure consistent
rendering; search for the listed entries (e.g., lines containing "Enhanced
mobile web interface with session sync and history panel", "Added
ThinkingStatusPill showing real-time token counts and elapsed time", etc.) and
replace each leading "•" with "-" and apply the same replacement for the other
affected ranges (notably the section also mentioned around lines 462-471).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e32933c8-7708-4aa8-ae7a-2a255470b088
📒 Files selected for processing (12)
docs/releases.mdsrc/main/stores/defaults.tssrc/main/stores/types.tssrc/prompts/maestro-system-prompt.mdsrc/renderer/components/FilePreview.tsxsrc/renderer/components/GroupChatInput.tsxsrc/renderer/components/InputArea.tsxsrc/renderer/components/Settings/tabs/GeneralTab.tsxsrc/renderer/hooks/settings/useSettings.tssrc/renderer/stores/settingsStore.tssrc/shared/settingsMetadata.tssrc/web/mobile/CommandInputBar.tsx
| - **Group chat participant management:** Remove button on participant cards lets you remove stale or unwanted participants from a group chat | ||
| - **Batch resume/abort:** New controls in the right panel for resuming or aborting batch operations | ||
| - **Default worktree directory:** Worktree configuration now defaults to the parent of the agent's working directory instead of blank | ||
| # Major 0.15.x Additions |
There was a problem hiding this comment.
Fix heading hierarchy to avoid broken doc outline.
These headings reset to H1 inside version sections. They should be subsection headings (e.g., ###) so navigation/TOC stays consistent.
Proposed fix
-# Major 0.15.x Additions
+### Major 0.15.x Additions
-# Smaller Changes in 014.x
+### Smaller Changes in 0.14.x
-# Other Changes
+### Other Changes
-# Onboarding, Wizard, and Tours
+### Onboarding, Wizard, and Tours
-# UI / UX Enhancements
+### UI / UX Enhancements
-# Auto Run Workflow Improvements
+### Auto Run Workflow Improvements
-# Application Behavior / Core Fixes
+### Application Behavior / Core Fixes
-# Update System
+### Update SystemAlso applies to: 80-80, 176-176, 268-268, 276-276, 286-286, 291-291, 297-297
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/releases.md` at line 20, Update the heading level for in-section titles
like "Major 0.15.x Additions" in docs/releases.md so they are subsection
headings (e.g., convert leading '#' to '###') rather than top-level H1; ensure
all similar headings mentioned (the ones at the other occurrences in this file)
are changed consistently so the document outline/TOC remains hierarchical and
navigation works correctly.
|
|
||
| The major contributions to 0.14.x remain: | ||
|
|
||
| 🗄️ Document Graphs. Launch from file preview or from the FIle tree panel. Explore relationships between Markdown documents that contain links between documents and to URLs. |
There was a problem hiding this comment.
Clean up copy typos in release text.
Minor wording/spelling issues found in changed lines (FIle → File, built in → built-in, will received → will receive, Github → GitHub).
Also applies to: 149-149, 153-153, 174-174
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/releases.md` at line 74, Fix the typos and wording in the release notes:
change "FIle" to "File" in the "🗄️ Document Graphs." line, replace "built in"
with "built-in", correct "will received" to "will receive", and change "Github"
to "GitHub"; apply the same corrections to the other occurrences noted (lines
referenced as 149, 153, 174) so all instances in docs/releases.md use the proper
capitalization and hyphenation.
|
|
||
| 🧙♂️ Added an in-tab wizard for generating Auto Run Playbooks via `/wizard` or a new button in the Auto Run panel. | ||
|
|
||
| # Smaller Changes in 014.x |
There was a problem hiding this comment.
Correct version label typo in heading.
014.x should be 0.14.x.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/releases.md` at line 80, Update the incorrect heading string "# Smaller
Changes in 014.x" to "# Smaller Changes in 0.14.x" so the version label is
correct; locate the heading line containing "Smaller Changes in 014.x" and
replace "014.x" with "0.14.x" to fix the typo.
| When a user wants an auto-run document (or playbook), create a detailed multi-document, multi-point Markdown implementation plan in the `{{AUTORUN_FOLDER}}` folder. Use the format `$PREFIX-XX.md`, where `XX` is the two-digit phase number (01, 02, etc.) and `$PREFIX` is the effort name. Always zero-pad phase numbers to ensure correct lexicographic sorting. Break phases by relevant context; do not mix unrelated task results in the same document. If working within a file, group and fix all type issues in that file together. If working with an MCP, keep all related tasks in the same document. Each task must be written as `- [ ] ...` so auto-run can execute and check them off with comments on completion. | ||
|
|
||
| **Multi-phase efforts:** When creating 3 or more phase documents for a single effort, place them in a dedicated subdirectory prefixed with today's date (e.g., `{{AUTORUN_FOLDER}}/YYYY-MM-DD-Feature-Name/FEATURE-NAME-01.md`). This allows users to add the entire folder at once and keeps related documents organized with a clear creation date. | ||
| **Multi-phase efforts:** When creating 3 or more phase documents for a single effort, place them in a single flat subdirectory directly under `{{AUTORUN_FOLDER}}`, prefixed with today's date (e.g., `{{AUTORUN_FOLDER}}/YYYY-MM-DD-Feature-Name/FEATURE-NAME-01.md`). Do NOT create nested subdirectories — all phase documents for a given effort go into one folder, never `project/feature/` nesting. This allows users to add the entire folder at once and keeps related documents organized with a clear creation date. |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify that autorun scanning functions recurse without depth limits
echo "=== Checking checkForMarkdownFiles recursion ==="
ast-grep --pattern $'async function checkForMarkdownFiles($$$) {
$$$
if ($_.isDirectory()) {
$$$
checkForMarkdownFiles($$$)
$$$
}
$$$
}'
echo ""
echo "=== Checking scanDirectory recursion ==="
ast-grep --pattern $'async function scanDirectory($$$) {
$$$
if ($_.isDirectory()) {
$$$
scanDirectory($$$)
$$$
}
$$$
}'
echo ""
echo "=== Searching for depth limit checks ==="
rg -n -C3 'depth|level|nesting' src/main/ipc/handlers/autorun.tsRepository: RunMaestro/Maestro
Length of output: 450
🏁 Script executed:
#!/bin/bash
# Find and examine the autorun.ts file
# First, locate the file
fd -e ts -e js | grep -i autorun
echo ""
echo "=== Checking file existence and size ==="
wc -l src/main/ipc/handlers/autorun.ts 2>/dev/null || echo "File not found at expected path"
echo ""
echo "=== Looking at lines 90-100 (around claimed scanDirectory) ==="
sed -n '90,100p' src/main/ipc/handlers/autorun.ts
echo ""
echo "=== Looking at lines 225-235 (around claimed checkForMarkdownFiles) ==="
sed -n '225,235p' src/main/ipc/handlers/autorun.ts
echo ""
echo "=== Searching for function definitions ==="
grep -n "function.*scanDirectory\|function.*checkForMarkdownFiles" src/main/ipc/handlers/autorun.tsRepository: RunMaestro/Maestro
Length of output: 2318
🏁 Script executed:
#!/bin/bash
# Read complete function implementations
echo "=== scanDirectory function (starting at line 78) ==="
sed -n '78,122p' src/main/ipc/handlers/autorun.ts
echo ""
echo "=== checkForMarkdownFiles function (starting at line 213) ==="
sed -n '213,235p' src/main/ipc/handlers/autorun.ts
echo ""
echo "=== Search for depth, maxDepth, or similar limit variables in file ==="
rg -n 'depth|maxDepth|max.*depth|recursion.*limit' src/main/ipc/handlers/autorun.tsRepository: RunMaestro/Maestro
Length of output: 2385
🏁 Script executed:
#!/bin/bash
# Verify the prompt file and check for any directory structure validation
echo "=== Reading maestro-system-prompt.md around line 48 ==="
sed -n '40,60p' src/prompts/maestro-system-prompt.md
echo ""
echo "=== Searching for directory structure validation in codebase ==="
rg -n 'YYYY-MM-DD|flat.*dir|nested.*dir|subdirectory.*limit|depth.*restriction' --max-count=20
echo ""
echo "=== Looking for tests related to directory structure ==="
fd -e test.ts -e spec.ts | xargs grep -l 'directory\|subdirectory\|nesting' 2>/dev/null | head -5
echo ""
echo "=== Check autorun.ts for any validation of flat structure ==="
rg -n 'validate.*dir|enforce.*dir|flat' src/main/ipc/handlers/autorun.tsRepository: RunMaestro/Maestro
Length of output: 11103
Add depth validation to enforce the single-level subdirectory rule for multi-phase efforts.
The maestro-system-prompt.md explicitly requires that multi-phase efforts use only one level of nesting ({{AUTORUN_FOLDER}}/YYYY-MM-DD-Feature-Name/) and forbids deeper structures. However, the scanning functions recurse without depth limits:
scanDirectory(line 78) recursively scans subdirectories with no maximum depthcheckForMarkdownFiles(line 213) recursively checks subdirectories with no maximum depth
This creates an enforcement gap: the documentation forbids nested structures like {{AUTORUN_FOLDER}}/2025-01-15-Feature/subfolder/nested/PHASE-01.md, but the implementation will silently discover and process phase files at any depth.
Add depth validation to reject files deeper than the required flat structure, or update the documentation to clarify that the rule is advisory.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/prompts/maestro-system-prompt.md` at line 48, The scanner currently
recurses without limits; update scanDirectory and checkForMarkdownFiles to
enforce a maximum subdirectory depth of 1 under the AUTORUN_FOLDER for
multi-phase efforts: add a depth (or relativeDepth) parameter to scanDirectory
and only recurse when depth < 1, and in checkForMarkdownFiles compute the path
depth relative to AUTORUN_FOLDER and either reject (throw/log an error) or skip
any markdown files found at depth > 1; ensure error messages reference the
offending path and the rule (single-level YYYY-MM-DD-Feature-Name folder) so
callers can surface the validation failure.
Greptile SummaryThis PR introduces a
Confidence Score: 4/5Safe to merge for desktop users; mobile web spell check is silently non-functional but defaults to off so there is no regression. The desktop implementation is complete, correct, and closely follows existing patterns. One gap: the mobile web CommandInputBar has the prop plumbing but App.tsx never passes the value, making the feature a no-op in that context. Because the default is false (disabled), this introduces no behavioral regression — it is a missing enhancement, not a breakage. src/web/mobile/App.tsx — the spellCheck prop must be plumbed through to CommandInputBar for the mobile web experience to match the PR description. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant GeneralTab as SettingsModal (GeneralTab)
participant Store as settingsStore (Zustand)
participant IPC as window.maestro.settings
participant ES as electron-store
participant InputArea
participant GroupChatInput
participant FilePreview
User->>GeneralTab: Toggle Spell Check checkbox
GeneralTab->>Store: setSpellCheck(value)
Store->>Store: set({ spellCheck: value })
Store->>IPC: settings.set('spellCheck', value)
IPC->>ES: persists value to disk
ES-->>IPC: confirmed
Note over Store,ES: On app startup
Store->>IPC: settings.getAll()
IPC->>ES: read all settings
ES-->>Store: { spellCheck: boolean, ... }
Store->>Store: patch.spellCheck = allSettings['spellCheck']
Store->>Store: settingsLoaded = true
Store-->>InputArea: useSettingsStore(s => s.spellCheck)
Store-->>GroupChatInput: useSettingsStore(s => s.spellCheck)
Store-->>FilePreview: useSettingsStore(s => s.spellCheck)
InputArea->>InputArea: textarea spellCheck={spellCheckEnabled}
GroupChatInput->>GroupChatInput: textarea spellCheck={spellCheckEnabled}
FilePreview->>FilePreview: textarea spellCheck={spellCheckEnabled}
|
Remove the spellCheck prop addition on CommandInputBar — App.tsx never passes the prop and the mobile web client has no path to read the desktop spellCheck setting today (settings sync flows over WebSocket and does not include spellCheck). The prop was a no-op enhancement, so revert to the prior hardcoded false to match actual behavior. Mobile spell check support belongs in a follow-up that adds the setting to the WebSocket settings sync.
1 participant
Summary
spellCheckboolean setting (default: off) under Settings > General > Spell CheckInputArea.tsx)GroupChatInput.tsx)FilePreview.tsx)Mobile/web client: not wired in this PR. The mobile UI receives settings over a separate WebSocket sync (
src/web/hooks/useSettings.ts) that does not currently exposespellCheck. Adding it cleanly there is a separate effort and out of scope here.Closes #253
Test plan
Summary by CodeRabbit