Skip to content

fix warp assert on pow of 2 #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
39ali wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

fix warp assert on pow of 2 #382

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
145f936
fix warp assert on pow of 2
39ali Apr 26, 2026
da05153
use u32::is_power_of_two()
39ali Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/cuda_std/src/warp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@ unsafe fn warp_shuffle_32(
}

assert!(
!(width & (width - 1)) != 0 && width <= 32,
width != 0 && (width & (width - 1)) == 0 && width <= 32,
Copy link
Copy Markdown
Contributor

@fee1-dead fee1-dead Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we use https://doc.rust-lang.org/std/primitive.u32.html#method.is_power_of_two here?

Copy link
Copy Markdown
Author

@39ali 39ali Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's true, we should use it, changing it

"width must be a power of 2 and less than or equal to 32"
);

Expand Down
Loading