Add accumulated randomized tests to xaes-256-gcm#835
Open
eligrubb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current tests for
xaes-256-gcminclude the C2SP test vectors but are missing the additional C2SP accumulated randomized tests.This PR adds the missing tests, verifying the output against the C2SP expected hash for both 10,000 and 1,000,000 iterations. The
shakecrate is added as a dev-only dependency enablingShake128hashing.NOTE
The
accumulated_randomized_1_000_000_iterationstakes a long time (~172s) when run using the default debug modecargo test. However, the test is fast (~2s) when run withcargo test --release. I added an#[ignore]to the test so it doesn't punish casualcargo testruns and updated the xaes-256-gcm CI workflow to--include-ignored. Is this solution acceptable?