Skip to content

Impl Serialize and Deserialize for Residue#170

Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom
haslersn:residue-serde
Jan 23, 2023
Merged

Impl Serialize and Deserialize for Residue#170
tarcieri merged 1 commit into
RustCrypto:masterfrom
haslersn:residue-serde

Conversation

@haslersn

Copy link
Copy Markdown
Contributor

No description provided.

@tarcieri

Copy link
Copy Markdown
Member

Needs a rebase

@haslersn

Copy link
Copy Markdown
Contributor Author

Needs a rebase

Done

Comment thread src/uint/modular/constant_mod.rs
@fjarri

fjarri commented Jan 23, 2023

Copy link
Copy Markdown
Contributor

Do you plan on supporting DynResidue? It will be slightly more complicated. May be worth it to have an option to split DynResidue objects into the residue proper, and the modulus info, so that big data structures involving multiple DynResidues could be serialized efficiently. (Or convert them to Residue? Effectively that's the same thing)

@tarcieri tarcieri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve/merge this for now and we can circle back on DynResidue

@tarcieri tarcieri merged commit 3d3c1ca into RustCrypto:master Jan 23, 2023
@haslersn haslersn deleted the residue-serde branch January 23, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants