Enforce valid modulus for DynResidueParams#240
Merged
Conversation
tarcieri
reviewed
May 22, 2023
tarcieri
reviewed
May 22, 2023
AaronFeickert
force-pushed
the
modulus-checks
branch
from
50d75ff to
a063e06
Compare
fjarri
reviewed
May 22, 2023
fjarri
reviewed
May 22, 2023
fjarri
reviewed
May 22, 2023
AaronFeickert
force-pushed
the
modulus-checks
branch
from
7b7ec19 to
b32a0a4
Compare
fjarri
reviewed
May 25, 2023
fjarri
reviewed
May 25, 2023
fjarri
approved these changes
May 25, 2023
tarcieri
reviewed
May 25, 2023
tarcieri
approved these changes
May 26, 2023
5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #232, it is possible to create
DynResidueParamswith an invalid modulus. If this happens, arithmetic operations will quietly produce invalid results.At the suggestion of @tarcieri, this PR takes steps toward enforcing modulus validity. It has
DynResidueParams::newpanic on an invalid modulus, which keeps its signature intact while safely failing, and deprecates it. It also introducesDynResidueParams::new_checked, which returns aCtOption. It also adds a few simple tests and updates the documentation.At the next breaking release, the checked behavior can move to
DynResidueParams::newif desired.