Add constant-time Uint::shr() and Uint::shl()#267
Merged
Conversation
fjarri
force-pushed
the
ct-shifts
branch
7 times, most recently
from
fe6f087 to
54e9f8f
Compare
tarcieri
approved these changes
Aug 28, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This overrides the
shr()implementation in #263 - this one is more efficient (O(LIMBS * log2(BITS)) instead of O(LIMBS^2)). ForU2048it's ~10x slower than the vartime equivalent.Question for @tarcieri : what behavior do we want on overflow?
shl()/shr()currently return 0, their vartime equivalents return the original value. I wonder if it would be better to return a pair(Self, CtChoice)where the second element indicates the overflow.