Move various operations on Words to a new primitves module#458
Conversation
95960ee to
5fe3a4a
Compare
|
I guess this is draft because it's WIP? Otherwise looks great so far |
|
Adjusted the names and added some comments. |
tarcieri
left a comment
There was a problem hiding this comment.
This seems good unless you wanted to add the Hacker's Delight overflow checks and such
|
If they're used elsewhere other than |
|
There is duplication between |
|
Not anymore. |
|
It seems like these two duplicate each other: https://github.com/RustCrypto/crypto-bigint/blob/00e1a60/src/const_choice.rs#L71-L85 And it's also duplicated here: https://github.com/RustCrypto/crypto-bigint/blob/00e1a60/src/modular/boxed_residue/mul.rs#L305 Potentially all three could call a common function? |
|
The one in |
TODO: review function names