Skip to content

Fix workflow YAML syntax#705

Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom
AaronFeickert:yaml-syntax
Dec 8, 2024
Merged

Fix workflow YAML syntax#705
tarcieri merged 1 commit into
RustCrypto:masterfrom
AaronFeickert:yaml-syntax

Conversation

@AaronFeickert

Copy link
Copy Markdown
Contributor

My IDE reports that certain branch and path specifications in the GitHub actions configurations are not strictly valid YAML. This PR fixes accordingly.

@tarcieri

tarcieri commented Dec 8, 2024

Copy link
Copy Markdown
Member

FWIW we use standard templates for our CI YAML everywhere. This would be a notable divergence.

I guess it's more technically correct? Obviously GitHub Actions promotes a single string to an array of strings or it wouldn't work, though I suppose technically that violates lints which are written to the precise letter of GitHub's schema (which is still somewhat ill-specified given the actual semantics, but I digress)

@AaronFeickert

Copy link
Copy Markdown
Contributor Author

Feel free to close if the resulting inconsistency with other repositories isn't worth it.

@tarcieri

tarcieri commented Dec 8, 2024

Copy link
Copy Markdown
Member

Maybe we can open some common issue to track updates to the boilerplate we should make everywhere

@AaronFeickert

Copy link
Copy Markdown
Contributor Author

Not sure where that would be opened. Really this is just because my (apparently very picky) IDE was giving errors on this. Regardless, I'd still advocate to merge it to make the YAML gods happy unless there are likely to be headaches bringing in changes from other repositories.

@tarcieri tarcieri merged commit 12d4a08 into RustCrypto:master Dec 8, 2024
@tarcieri

tarcieri commented Dec 8, 2024

Copy link
Copy Markdown
Member

Fine

@AaronFeickert AaronFeickert deleted the yaml-syntax branch December 8, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants