k256/p256: impl FromPublicKey/FromSecretKey and ops::MulBase#100
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
- Coverage 52.83% 52.66% -0.18%
==========================================
Files 19 19
Lines 3435 3437 +2
==========================================
- Hits 1815 1810 -5
- Misses 1620 1627 +7
Continue to review full report at Codecov.
|
...and remove the now legacy `FixedBaseScalarMul` trait. This commit impls the changes from RustCrypto/traits#229 and RustCrypto/traits#230: - Adds a `FromSecretKey` impl on `Scalar` - Adds a `FromPublicKey` impl on `AffinePoint` - Adds `MulBase` impl on `Scalar`
tarcieri
force-pushed
the
from-public-secret-key-and-mul-base
branch
from
605d36d to
89da786
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and remove the now legacy
FixedBaseScalarMultrait.This commit impls the changes from RustCrypto/traits#229 and RustCrypto/traits#230:
FromSecretKeyimpl onScalarFromPublicKeyimpl onAffinePointMulBaseimpl onScalar