Skip to content

k256/p256: use new elliptic_curve::encoding module#117

Merged
tarcieri merged 1 commit into
masterfrom
elliptic-curve-encoding-module
Aug 5, 2020
Merged

k256/p256: use new elliptic_curve::encoding module#117
tarcieri merged 1 commit into
masterfrom
elliptic-curve-encoding-module

Conversation

@tarcieri

@tarcieri tarcieri commented Aug 4, 2020

Copy link
Copy Markdown
Member

Impls the new FromBytes traits introduced in RustCrypto/traits#247, and changes to_bytes() to return ElementBytes.

@codecov-commenter

codecov-commenter commented Aug 4, 2020

Copy link
Copy Markdown

Codecov Report

Merging #117 into master will increase coverage by 0.07%.
The diff coverage is 67.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   51.53%   51.60%   +0.07%     
==========================================
  Files          20       20              
  Lines        3489     3484       -5     
==========================================
  Hits         1798     1798              
+ Misses       1691     1686       -5     
Impacted Files Coverage Δ
k256/src/arithmetic/field/field_10x26.rs 0.00% <0.00%> (ø)
k256/src/arithmetic/field/field_montgomery.rs 0.00% <0.00%> (ø)
k256/src/arithmetic/scalar/scalar_8x32.rs 0.00% <0.00%> (ø)
k256/src/ecdsa/recoverable.rs 0.00% <ø> (ø)
k256/src/ecdsa/signer.rs 0.00% <0.00%> (ø)
k256/src/ecdsa/verifier.rs 0.00% <0.00%> (ø)
p256/src/ecdsa.rs 0.00% <0.00%> (ø)
k256/src/arithmetic/scalar.rs 73.68% <54.54%> (+0.44%) ⬆️
p256/src/arithmetic/scalar.rs 64.23% <78.57%> (+0.42%) ⬆️
k256/src/arithmetic.rs 84.32% <100.00%> (-0.06%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf64b3...ef2e441. Read the comment docs.

@tarcieri tarcieri marked this pull request as draft August 4, 2020 22:06
@tarcieri tarcieri force-pushed the elliptic-curve-encoding-module branch from 3ba4193 to a10312c Compare August 5, 2020 01:19
@tarcieri tarcieri marked this pull request as ready for review August 5, 2020 01:22
@tarcieri tarcieri force-pushed the elliptic-curve-encoding-module branch 2 times, most recently from cd75a4f to 58e86a7 Compare August 5, 2020 01:34
Impls the new `FromBytes` traits introduced in RustCrypto/traits#247,
and changes `to_bytes()` to return `ElementBytes`.
@tarcieri tarcieri force-pushed the elliptic-curve-encoding-module branch from 58e86a7 to ef2e441 Compare August 5, 2020 01:35
@tarcieri tarcieri merged commit 4b044a0 into master Aug 5, 2020
@tarcieri tarcieri deleted the elliptic-curve-encoding-module branch August 5, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants