Skip to content

Add ed448#1208

Closed
baloo wants to merge 17 commits into
RustCrypto:masterfrom
baloo:baloo/ed448
Closed

Add ed448#1208
baloo wants to merge 17 commits into
RustCrypto:masterfrom
baloo:baloo/ed448

Conversation

@baloo

@baloo baloo commented May 29, 2025

Copy link
Copy Markdown
Member

This is a rebase of #1121

I ended up moving some of the implementation to primeorder

@baloo baloo mentioned this pull request May 29, 2025
@baloo baloo marked this pull request as draft May 29, 2025 04:26
mikelodder7 and others added 16 commits May 28, 2025 21:27
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
@baloo baloo force-pushed the baloo/ed448 branch 2 times, most recently from 21f44de to 21e3b80 Compare May 29, 2025 04:49
@tarcieri

Copy link
Copy Markdown
Member

Like I said in #1121, it's weird to use primeorder with ed448 because ed(wards)448 is not a prime order curve. To the extent there's reusable functionality that doesn't depend on it, we should maybe try to find a better home for such functionality, like elliptic-curve

It'd be good to keep ed448 close to the original crate, and we can document some work items to do as followups.

@baloo

baloo commented May 30, 2025

Copy link
Copy Markdown
Member Author

Those were mostly the mul macros, but I haven't got time to refactor that last commit. I'll give it another shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants