Skip to content

k256: eagerly verify ECDSA scalars are in range#143

Merged
tarcieri merged 1 commit into
masterfrom
k256/infallible-ecdsa-r-and-s-conversions
Aug 26, 2020
Merged

k256: eagerly verify ECDSA scalars are in range#143
tarcieri merged 1 commit into
masterfrom
k256/infallible-ecdsa-r-and-s-conversions

Conversation

@tarcieri

Copy link
Copy Markdown
Member

...when the ecdsa feature of the crate is enabled.

This provides infallible access to the ECDSA r() and s() scalars.

@codecov-commenter

codecov-commenter commented Aug 26, 2020

Copy link
Copy Markdown

Codecov Report

Merging #143 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   50.73%   50.75%   +0.02%     
==========================================
  Files          21       21              
  Lines        3491     3491              
==========================================
+ Hits         1771     1772       +1     
+ Misses       1720     1719       -1     
Impacted Files Coverage Δ
k256/src/ecdsa/recoverable.rs 0.00% <0.00%> (ø)
k256/src/ecdsa/signer.rs 0.00% <0.00%> (ø)
k256/src/arithmetic/scalar/scalar_4x64.rs 76.19% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd701d0...154deb2. Read the comment docs.

...when the `ecdsa` feature of the crate is enabled.

This provides infallible access to the ECDSA `r()` and `s()` scalars.
@tarcieri tarcieri force-pushed the k256/infallible-ecdsa-r-and-s-conversions branch from 759b133 to 154deb2 Compare August 26, 2020 00:56
@tarcieri tarcieri merged commit 8206097 into master Aug 26, 2020
@tarcieri tarcieri deleted the k256/infallible-ecdsa-r-and-s-conversions branch August 26, 2020 00:59
@tarcieri tarcieri mentioned this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants