k256: use NonZeroScalar for ECDSA signature components#144
Merged
Conversation
Simplifies checks that `r` and `s` are non-zero by using the `NonZeroScalar` type.
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 50.75% 50.81% +0.05%
==========================================
Files 21 21
Lines 3491 3487 -4
==========================================
Hits 1772 1772
+ Misses 1719 1715 -4
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies checks that
randsare non-zero by using theNonZeroScalartype.